Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database image name corrected #5402

Closed
wants to merge 1 commit into from
Closed

Database image name corrected #5402

wants to merge 1 commit into from

Conversation

manitaggarwal
Copy link

Description of what you did:

While using the docker container database was pulled from postgres instead of mongo.

@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #5402 into master will increase coverage by 6.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5402      +/-   ##
==========================================
+ Coverage   11.67%   17.72%   +6.05%     
==========================================
  Files         608      686      +78     
  Lines        8026    10136    +2110     
  Branches     1147     1636     +489     
==========================================
+ Hits          937     1797     +860     
- Misses       6051     6954     +903     
- Partials     1038     1385     +347     
Flag Coverage Δ
#front 13.15% <23.50%> (+1.48%) ⬆️
#unit 37.00% <100.00%> (?)
Impacted Files Coverage Δ
...rapi-admin/admin/src/contexts/MarketPlace/index.js 0.00% <0.00%> (-80.00%) ⬇️
packages/strapi-plugin-email/admin/src/index.js 0.00% <0.00%> (ø)
packages/strapi-plugin-upload/admin/src/index.js 0.00% <0.00%> (ø)
...ges/strapi-plugin-documentation/admin/src/index.js 0.00% <0.00%> (ø)
...strapi-plugin-users-permissions/admin/src/index.js 0.00% <0.00%> (ø)
...s-permissions/admin/src/components/Plugin/index.js 0.00% <0.00%> (ø)
...permissions/admin/src/containers/EditPage/index.js 0.00% <0.00%> (ø)
...ilder/admin/src/utils/getAttributeDisplayedType.js 0.00% <0.00%> (ø)
packages/strapi/lib/load/load-config-files.js 83.33% <0.00%> (ø)
...tainers/ListView/utils/generateSearchFromObject.js 100.00% <0.00%> (ø)
... and 109 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 611284b...1a99365. Read the comment docs.

@lauriejim
Copy link
Contributor

Hello! Thank you for this fix!
It's the same as this PR - #5398
Please check the DCO and I will merge your PR.
Thank you!

@lauriejim lauriejim added source: docs Documentation changes issue: enhancement Issue suggesting an enhancement to an existing feature labels Mar 5, 2020
@alexandrebodin
Copy link
Member

Hi I'm closing this issue as a duplicate of #5398

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants