Allow deleting file that is already deleted in Cloudinary #8410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arnelle Balane <arnellebalane@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #8410 +/- ##
=======================================
Coverage 33.27% 33.27%
=======================================
Files 1220 1220
Lines 13625 13625
Branches 1357 1357
=======================================
Hits 4534 4534
Misses 8207 8207
Partials 884 884
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
alexandrebodin
approved these changes
Nov 10, 2020
alexandrebodin
added
source: core:upload
RajNandigalla
pushed a commit
to RajNandigalla/strapi
that referenced
this pull request
Nov 11, 2020
Signed-off-by: Arnelle Balane <arnellebalane@gmail.com> Signed-off-by: Raj Nandigalla <raj.nandigalla@ril.com>
hdeadman
pushed a commit
to hdeadman/strapi
that referenced
this pull request
Nov 12, 2020
Signed-off-by: Arnelle Balane <arnellebalane@gmail.com>
petersg83
pushed a commit
that referenced
this pull request
Nov 13, 2020
Signed-off-by: Arnelle Balane <arnellebalane@gmail.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Handle the case with strapi-provider-upload-cloudinary when trying to delete a file that is already deleted in Cloudinary. Cloudinary responds with
{ result: 'not found' }when trying to delete a non-existent file. This is added as an extra condition to be checked in strapi-provider-upload-cloudinary before throwing an error.Why is it needed?
When using strapi-provider-upload-cloudinary and the file is already deleted in Cloudinary, that file cannot be deleted from the Strapi UI and throws an internal server error.
Related issue(s)/PR(s)
Fix #5729 Cannot delete file already deleted in Cloudinary