Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8796 - fix relation typo in fr #8899

Merged
merged 5 commits into from
Jan 14, 2021

Conversation

croatian91
Copy link
Contributor

fix french translation in content type builder plugin

fix french translation in content type builder plugin
@strapi-cla
Copy link

strapi-cla commented Dec 16, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #8899 (9703a6c) into master (dd0f8f0) will increase coverage by 0.03%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8899      +/-   ##
==========================================
+ Coverage   34.60%   34.64%   +0.03%     
==========================================
  Files        1308     1308              
  Lines       14416    14431      +15     
  Branches     1427     1432       +5     
==========================================
+ Hits         4989     4999      +10     
- Misses       8514     8518       +4     
- Partials      913      914       +1     
Flag Coverage Δ
front 26.04% <ø> (ø)
unit 54.85% <70.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/strapi-utils/lib/build-query.js 18.84% <0.00%> (-1.48%) ⬇️
packages/strapi-utils/lib/content-types.js 91.66% <100.00%> (ø)
packages/strapi/lib/core-api/service.js 77.77% <100.00%> (+5.05%) ⬆️
packages/strapi/lib/services/entity-service.js 44.44% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f5a932...9703a6c. Read the comment docs.

@croatian91
Copy link
Contributor Author

After:

Screenshot 2020-12-16 at 03 02 47

Screenshot 2020-12-16 at 03 02 55

Screenshot 2020-12-16 at 03 03 05

@croatian91
Copy link
Contributor Author

@soupette up

Copy link

@maevalienard maevalienard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)
Thank you for fixing it!

Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin alexandrebodin added this to the 3.4.4 milestone Jan 14, 2021
@alexandrebodin alexandrebodin merged commit 0b752b4 into strapi:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants