This repository has been archived by the owner on Aug 16, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 314
[Consensus] Add BlockValidationState to ChainedHeader ToString() #2678
Merged
dangershony
merged 8 commits into
stratisproject:master
from
fassadlr:multiple-reorgs-logs
Nov 5, 2018
Merged
[Consensus] Add BlockValidationState to ChainedHeader ToString() #2678
dangershony
merged 8 commits into
stratisproject:master
from
fassadlr:multiple-reorgs-logs
Nov 5, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fassadlr
changed the title
[Consensus] Add BlockValidationState to ChainedHeader
[Consensus] Add BlockValidationState to ChainedHeader ToString()
Nov 5, 2018
zeptin
suggested changes
Nov 5, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits
zeptin
approved these changes
Nov 5, 2018
dangershony
reviewed
Nov 5, 2018
@@ -591,6 +599,8 @@ public bool BlockDataDownloaded(ChainedHeader chainedHeader, Block block) | |||
bool partialValidationRequired = chainedHeader.Previous.BlockValidationState == ValidationState.PartiallyValidated | |||
|| chainedHeader.Previous.BlockValidationState == ValidationState.FullyValidated; | |||
|
|||
this.logger.LogTrace("[BLOCK_DOWNLOAD_PREVIOUS_STATE]{0}:{1}:{2}", nameof(chainedHeader.Previous), chainedHeader.Previous, chainedHeader.Previous.BlockValidationState); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to trace this chainedHeader.Previous.BlockValidationState
its traced as part of the Previous
ChainedHeader
Suggested change
this.logger.LogTrace("[BLOCK_DOWNLOAD_PREVIOUS_STATE]{0}:{1}:{2}", nameof(chainedHeader.Previous), chainedHeader.Previous, chainedHeader.Previous.BlockValidationState); | |
this.logger.LogTrace("[BLOCK_DOWNLOAD_PREVIOUS_STATE]{0}:{1}", nameof(chainedHeader.Previous), chainedHeader.Previous); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.