Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"film_roll:moved" does not trigger : When Carousel width is more than all carousels combined #35

Closed
prashantsani opened this issue Apr 3, 2015 · 5 comments

Comments

@prashantsani
Copy link

Hello,

"film_roll:moved" does not trigger in following example :

http://codepen.io/Prashantsani/pen/emoXGO
Reason : The carousel width is more than the number of items in it.

But the same thing works in following example :
http://codepen.io/Prashantsani/pen/WbWmZY
Reason : carousel width is bigger than number of items in it.

Thanks.

@straydogstudio
Copy link
Owner

I guess that doesn't hurt to fire that event. The thing is, nothing has moved. But I can see the value of having a single event fire in both instances. (I'll probably do it anyway, but it is worth thinking about.) Can you think of any situations where this would not be desirable?

@prashantsani
Copy link
Author

Hey!
Thanks for the reply.
We have a thumbnail carousel, and whenever a new item triggers, we change the background and the text via ""film_roll:moved"".

So, i have edited my previous pens to show the effect that we have in our code, "film_roll:moved".

http://codepen.io/Prashantsani/pen/emoXGO
http://codepen.io/Prashantsani/pen/WbWmZY

(instead of "film_roll:moved" we can also have something like "film_roll:change" )

Thanks,

@straydogstudio
Copy link
Owner

That's true, we could add another event that would always happen.

@prashantsani
Copy link
Author

Is there any workaround for this?
I have added the code for "film_roll:moved" in the click handler event.

Here is codepen :
http://codepen.io/Prashantsani/pen/WbBwPX
(it works fine.....but it fires twice, if the carousel width is smaller then number of items in it)

@straydogstudio
Copy link
Owner

Fixed with 0.1.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants