Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelog.config.js can't be kept out of npm package #161

Open
slightlytwisted opened this issue Mar 30, 2020 · 2 comments
Open

changelog.config.js can't be kept out of npm package #161

slightlytwisted opened this issue Mar 30, 2020 · 2 comments

Comments

@slightlytwisted
Copy link

When running npm pack, the changelog.cofig.js file gets included - and it is not possible to exclude it because .npmignore always includes any file that looks like a changelog. This is somewhat undesirable as it means shipping dev configuration files.

It might be a good idea to support an alternate config file name (.gitcz.js or .changelog.config.js) to avoid colliding with what npm considers to be a changelog.

@rodrigograca31
Copy link
Collaborator

They actually already support other names:

git-cz/lib/getConfig.js

Lines 7 to 11 in c0e4ca8

const configFiles = [
'.git-cz.json',
'changelog.config.js',
'changelog.config.json'
];

I wish they supported a file in a "global location" (your home dir)

@rodrigograca31
Copy link
Collaborator

@slightlytwisted does using .git-cz.json solve this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants