fix: ensure js file is copied to expected place #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamich
pushed a commit
that referenced
this pull request
May 17, 2022
## [3.4.3](v3.4.2...v3.4.3) (2022-05-17) ### Bug Fixes * ensure js file is copied to expected place ([#838](#838)) ([90e2e1d](90e2e1d))
|
🎉 This PR is included in version 3.4.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Confirmed, thank you for clearing this so quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cpy-cliwas upgraded to a new major version by #818 which has since resulted ingetBigInt.jsbeing copied intolib/src/getBigInt.jsinstead oflib/getBigInt.jswhich has broken the latest release (#837).I can't see what the breaking change in
cpy-clithat is causing this, but frankly we've only gotgetBigInt.jsto support lower versions of node so we shouldn't be expecting to copy any other js file & so I've just replaced it withcpwhich is available on standard Linux & MacOS systems (and I believe PowerShell on Windows).This'll unbreak the library for the meantime at least - we can always add
cpy-cliback in future.Resolves #837