Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add usePreviousDistinct #551

Merged
merged 4 commits into from
Aug 25, 2019
Merged

feat: add usePreviousDistinct #551

merged 4 commits into from
Aug 25, 2019

Conversation

paul-sachs
Copy link
Contributor

Fixes #476

Copy link
Contributor

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice hook! It looks good to me, but it would need an example file for storybook and some changes on test file.

EDIT: sorry, just realize the example is already there 💯

src/__tests__/usePreviousDistinct.test.tsx Outdated Show resolved Hide resolved
src/__tests__/usePreviousDistinct.test.tsx Outdated Show resolved Hide resolved
@Belco90
Copy link
Contributor

Belco90 commented Aug 23, 2019

Looks good to me! Let's see what @xobotyi @streamich think.

@xobotyi
Copy link
Contributor

xobotyi commented Aug 23, 2019

LGTM too

@paul-sachs
Copy link
Contributor Author

paul-sachs commented Aug 23, 2019

Nice hook! It looks good to me, but it would need an example file for storybook and some changes on test file.

EDIT: sorry, just realize the example is already there 💯

No, this was a good catch. I realize i hadn't even run storybook to check if the docs were picked up. I've pushed an update with the docs.

@Belco90 Belco90 merged commit 6c3e569 into streamich:master Aug 25, 2019
streamich pushed a commit that referenced this pull request Aug 25, 2019
# [11.3.0](v11.2.0...v11.3.0) (2019-08-25)

### Features

* add usePreviousDistinct ([#551](#551)) ([6c3e569](6c3e569))
@streamich
Copy link
Owner

🎉 This PR is included in version 11.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

usePrevious only tracks the previous of the last render and is affected by other hooks
4 participants