Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: useUpdateEffect returns optional cleanup function #864

Merged
merged 1 commit into from
Jan 7, 2020
Merged

fix: useUpdateEffect returns optional cleanup function #864

merged 1 commit into from
Jan 7, 2020

Conversation

adesurirey
Copy link
Contributor

@adesurirey adesurirey commented Jan 7, 2020 •
edited

Fixes #863

Description

useUpdateEffect does not return the result of the effect passed, this results in cleanup function never being called on unmount. This PR fixes it by making useUpdateEffect return the result of the passed effect.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as before)

Checklist

  • Read the Contributing Guide
  • Perform a code self-review
  • Comment the code, particularly in hard-to-understand areas
  • Add documentation
  • Add hook's story at Storybook
  • Cover changes with tests
  • Ensure the test suite passes (yarn test)
  • Provide 100% tests coverage
  • Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure.
  • Make sure types are fine (yarn lint:types).

streamich
streamich approved these changes Jan 7, 2020
View reviewed changes
Copy link
Owner

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@streamich streamich merged commit 7960127 into streamich:master Jan 7, 2020
streamich pushed a commit that referenced this pull request Jan 7, 2020
@semantic-release-bot
chore(release): 13.14.1 [skip ci]
c893fe3 
## [13.14.1](v13.14.0...v13.14.1) (2020-01-07)

### Bug Fixes

* useUpdateEffect returns optional cleanup function ([0ce421c](0ce421c))
* useUpdateEffect returns optional cleanup function ([#864](#864)) ([7960127](7960127))
@streamich
Copy link
Owner

🎉 This PR is included in version 13.14.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@adesurirey adesurirey mentioned this pull request Jan 7, 2020
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streamich streamich streamich approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useUpdateEffect not calling returned function on unmount
2 participants
@adesurirey @streamich