-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dialog boxes don't function when nested inside fragments (fragments inside fragments not supported) #8635
Comments
Hey @mzientek, according to our concept docs for fragements in the "Limitations and unsupported behavior" section, we unfortunately right now do not allow nesting fragments inside each other. Since dialog is using fragments under-the-hood, the same applies to dialog. We will look into improving the UX and throw an error or similar to make this clearer! If this behavior will change in the future, we will put it into the respective release notes. |
Ok, thanks. |
) We previously used `ctx.current_fragment_id` to determine whether a script runner execution is a full script run or a fragment rerun. We later switched to using `ctx.fragment_ids_this_run` to support multiple fragments being run from a single script runner but still had the script runner be responsible for setting `ctx.current_fragment_id` outside of the fragment's outer function. It turns out that having the fragment's outer function be reponsible for this fixes the issue we were having with nested fragments not working correctly, so this PR makes the simple required change to fix nested fragments/dialogs. Closes #8635
) We previously used `ctx.current_fragment_id` to determine whether a script runner execution is a full script run or a fragment rerun. We later switched to using `ctx.fragment_ids_this_run` to support multiple fragments being run from a single script runner but still had the script runner be responsible for setting `ctx.current_fragment_id` outside of the fragment's outer function. It turns out that having the fragment's outer function be reponsible for this fixes the issue we were having with nested fragments not working correctly, so this PR makes the simple required change to fix nested fragments/dialogs. Closes #8635
Checklist
Summary
I'm trying to present a dialog box within a fragment, however, when the dialog/modal is nested inside a fragment, it doesn't interact correctly and doesn't close. The content inside the box closes when interacting with it, but the title and the dialog box itself remain open.
Reproducible Code Example
Steps To Reproduce
Expected Behavior
Expected that the dialog box would be able to function within a fragment and that the close and rerun, would in fact close the dialog box.
Current Behavior
No response
Is this a regression?
Debug info
Additional Information
No response
The text was updated successfully, but these errors were encountered: