Set ctx.current_fragment_id in both full script and fragment runs #8931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdonato
force-pushed
the
vdonato/fix/8635
branch
from
af9d3c8
to
871736c
Compare
vdonato
changed the title
vdonato
force-pushed
the
vdonato/fix/8635
branch
from
871736c
to
e819f5c
Compare
vdonato
force-pushed
the
vdonato/fix/8635
branch
from
e819f5c
to
64cab9e
Compare
vdonato
added a commit
that referenced
this pull request
Jun 20, 2024
) We previously used `ctx.current_fragment_id` to determine whether a script runner execution is a full script run or a fragment rerun. We later switched to using `ctx.fragment_ids_this_run` to support multiple fragments being run from a single script runner but still had the script runner be responsible for setting `ctx.current_fragment_id` outside of the fragment's outer function. It turns out that having the fragment's outer function be reponsible for this fixes the issue we were having with nested fragments not working correctly, so this PR makes the simple required change to fix nested fragments/dialogs. Closes #8635
vdonato
added a commit
that referenced
this pull request
Jun 21, 2024
) We previously used `ctx.current_fragment_id` to determine whether a script runner execution is a full script run or a fragment rerun. We later switched to using `ctx.fragment_ids_this_run` to support multiple fragments being run from a single script runner but still had the script runner be responsible for setting `ctx.current_fragment_id` outside of the fragment's outer function. It turns out that having the fragment's outer function be reponsible for this fixes the issue we were having with nested fragments not working correctly, so this PR makes the simple required change to fix nested fragments/dialogs. Closes #8635
vdonato
added a commit
that referenced
this pull request
Jul 1, 2024
) We previously used `ctx.current_fragment_id` to determine whether a script runner execution is a full script run or a fragment rerun. We later switched to using `ctx.fragment_ids_this_run` to support multiple fragments being run from a single script runner but still had the script runner be responsible for setting `ctx.current_fragment_id` outside of the fragment's outer function. It turns out that having the fragment's outer function be reponsible for this fixes the issue we were having with nested fragments not working correctly, so this PR makes the simple required change to fix nested fragments/dialogs. Closes #8635
vdonato
added a commit
that referenced
this pull request
Jul 1, 2024
) We previously used `ctx.current_fragment_id` to determine whether a script runner execution is a full script run or a fragment rerun. We later switched to using `ctx.fragment_ids_this_run` to support multiple fragments being run from a single script runner but still had the script runner be responsible for setting `ctx.current_fragment_id` outside of the fragment's outer function. It turns out that having the fragment's outer function be reponsible for this fixes the issue we were having with nested fragments not working correctly, so this PR makes the simple required change to fix nested fragments/dialogs. Closes #8635
vdonato
added a commit
that referenced
this pull request
Jul 2, 2024
) We previously used `ctx.current_fragment_id` to determine whether a script runner execution is a full script run or a fragment rerun. We later switched to using `ctx.fragment_ids_this_run` to support multiple fragments being run from a single script runner but still had the script runner be responsible for setting `ctx.current_fragment_id` outside of the fragment's outer function. It turns out that having the fragment's outer function be reponsible for this fixes the issue we were having with nested fragments not working correctly, so this PR makes the simple required change to fix nested fragments/dialogs. Closes #8635
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously used
ctx.current_fragment_idto determine whether a script runner execution is a fullscript run or a fragment rerun. We later switched to using
ctx.fragment_ids_this_runto supportmultiple fragments being run from a single script runner but still had the script runner be responsible
for setting
ctx.current_fragment_idoutside of the fragment's outer function.It turns out that having the fragment's outer function be reponsible for this fixes the issue we were having
with nested fragments not working correctly, so this PR makes the simple required change to fix nested
fragments/dialogs.
Closes #8635