Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

st.experimental_dialog feels a bit laggy when closing #8747

Closed
3 of 4 tasks
lukasmasuch opened this issue May 23, 2024 · 1 comment · Fixed by #9023
Closed
3 of 4 tasks

st.experimental_dialog feels a bit laggy when closing #8747

lukasmasuch opened this issue May 23, 2024 · 1 comment · Fixed by #9023
Assignees
Labels
feature:st.dialog type:enhancement Requests for feature enhancements or new features

Comments

@lukasmasuch
Copy link
Collaborator

Checklist

  • I have searched the existing issues for similar issues.
  • I added a very descriptive title to this issue.
  • I have provided sufficient information below to help reproduce this issue.

Summary

When closing a dialog created via st.experimental_dialog, there is a short lag when closing the dialog:

Screen.Recording.2024-05-23.at.14.39.33.mov

The same doesn't happen with other native dialogs (e.g. about dialog):

Screen.Recording.2024-05-23.at.14.42.41.mov

Reproducible Code Example

import streamlit as st

@st.experimental_dialog("Hello")
def hello_world():
    st.write("Hello World")

hello_world()

Steps To Reproduce

No response

Expected Behavior

No response

Current Behavior

No response

Is this a regression?

  • Yes, this used to work in a previous version.

Debug info

  • Streamlit version: 1.34
  • Python version: 3.10
  • Operating System: MacOS
  • Browser: Chrome

Additional Information

No response

@lukasmasuch lukasmasuch added type:bug Something isn't working status:needs-triage Has not been triaged by the Streamlit team feature:st.dialog labels May 23, 2024
Copy link

If this issue affects you, please react with a 👍 (thumbs up emoji) to the initial post.

Your feedback helps us prioritize which bugs to investigate and address first.

Visits

@lukasmasuch lukasmasuch added status:confirmed Bug has been confirmed by the Streamlit team and removed status:needs-triage Has not been triaged by the Streamlit team labels May 23, 2024
@raethlein raethlein removed the type:bug Something isn't working label May 23, 2024
@lukasmasuch lukasmasuch added type:enhancement Requests for feature enhancements or new features and removed status:confirmed Bug has been confirmed by the Streamlit team labels May 23, 2024
@streamlit streamlit deleted a comment from github-actions bot May 23, 2024
sfc-gh-pchiu pushed a commit to sfc-gh-pchiu/streamlit that referenced this issue Sep 3, 2024
## Describe your changes

Closes streamlit#8747

Instead of using Baseweb Modal's `isOpen` prop, we return an empty
element when `isOpen` is set.

**Contribution License Agreement**

By submitting this pull request you agree that all contributions to this
project are made under the Apache 2.0 license.
sfc-gh-pchiu pushed a commit to sfc-gh-pchiu/streamlit that referenced this issue Sep 3, 2024
## Describe your changes

Closes streamlit#8747

Instead of using Baseweb Modal's `isOpen` prop, we return an empty
element when `isOpen` is set.

**Contribution License Agreement**

By submitting this pull request you agree that all contributions to this
project are made under the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:st.dialog type:enhancement Requests for feature enhancements or new features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants