FIX: Support hashing for Enum classes #5426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @lluissalord for this PR! LGTM 👍 |
kajarenc
approved these changes
Sep 27, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
In our project, we heavily rely on
Enumclasses in order to enumerate and classify types of things. However, currently they are not supported by Streamlit for caching withst.experimental_memobecause they are not correctly hashed.What kind of change does this PR introduce?
🧠 Description of Changes
Support for
Enumclass hashing forst.experimental_memo🧪 Testing Done
🌐 References
experimental_memofails to hash input arguments that are class instances #4417Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.