Fix Plotly Charts when exiting out of fullscreen #5645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnOctopus
approved these changes
Nov 3, 2022
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Nov 8, 2022
* develop: Add mypy fixes (streamlit#5662) Don't render stale st.snow and st.ballons elements (streamlit#5401) Fix unevaluated dataframe exception formatting (streamlit#5657) Update aboutDialog to check SessionInfo.isSet() before referring the instance (streamlit#5518) Replace assertEquals->assertEqual to silence deprecation warnings (streamlit#5648) Reworke AttrDict for st.secrets to explicitly disallow item and attribute assignment (streamlit#5621) Fix pydoc command for streamlit package (streamlit#5535) Temporarily have /st-allowed-message-origins double as a healthcheck (streamlit#5642) Fix Plotly Charts when exiting out of fullscreen (streamlit#5645) Flaky test e2e fixes (streamlit#5610)
kmcgrady
pushed a commit
to kmcgrady/streamlit
that referenced
this pull request
Nov 8, 2022
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
This is a regression. #5644
Please describe the project or issue background here
What kind of change does this PR introduce?
🧠 Description of Changes
Adds an else clause when fullscreen is not true and resets the height and width
Add bullet points summarizing your changes here
Revised:
Insert screenshot of your updated UI/code here
Screen.Recording.2022-11-03.at.10.25.27.AM.mov
Current:
Screen.Recording.2022-11-03.at.10.23.34.AM.mov
Insert screenshot of existing UI/code here
🧪 Testing Done
🌐 References
Does this depend on other work, documents, or tickets?
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.