Use new annotation features in DeltaGenerator #6045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasmasuch
reviewed
Feb 1, 2023
| ) -> Optional[DG]: | ||
| data: Data = None, | ||
| **kwargs: DataFrame | ||
| | npt.NDArray[Any] |
There was a problem hiding this comment.
I'm not 100% sure, but I think there was some kind of problem with older numpy versions if NDArray is used that way. The reason is that NDArray was only added a few versions ago. Maybe you can check if everything works fine if you select the oldest numpy version we support.
lukasmasuch
reviewed
Feb 1, 2023
| ) -> Optional[DG]: | ||
| data: Data = None, | ||
| **kwargs: DataFrame | ||
| | npt.NDArray[Any] |
There was a problem hiding this comment.
See the comment above
lukasmasuch
approved these changes
Feb 1, 2023
|
Appears to work fine (no errors when running tests) on numpy 1.18, which is as far back as I can readily install in my dev env. So I think it's fine. The change is about making use of lazy annotations, so nothing in them should matter for runtime. |
eric-skydio
pushed a commit
to eric-skydio/streamlit
that referenced
this pull request
Dec 20, 2023
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Mar 22, 2024
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
sfc-gh-pchiu
pushed a commit
to sfc-gh-pchiu/streamlit
that referenced
this pull request
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
Continuing the gradual adoption of
from __future__ import annotationsWhat kind of change does this PR introduce?