Fix button height #6738
Merged
Fix button height #6738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… small differences
mayagbarnes
reviewed
May 24, 2023
| @@ -80,6 +80,7 @@ export const StyledBaseButton = styled.button<RequiredBaseButtonProps>( | |||
| justifyContent: "center", | |||
| fontWeight: theme.fontWeights.normal, | |||
| padding: `${theme.spacing.xs} ${theme.spacing.md}`, | |||
| minHeight: "38.4px", | |||
There was a problem hiding this comment.
Understandable as a short term solution, but this is a definitely a strange value 🙃
mayagbarnes
approved these changes
May 24, 2023
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
sfc-gh-jgarcia
added
type:bug
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Jun 14, 2023
* develop: Bump dependencies of component-lib (streamlit#6830) Make `streamlit config show` honor newlines (streamlit#6758) Update comments on magic.py (streamlit#6833) Add tests for component-lib (streamlit#6580) Fix button height (streamlit#6738) Add `to_pandas` method to convert inputs to pandas DataFrames (streamlit#6668) hash_funcs for st.cache_data and st.cache_resource (streamlit#6502)
eric-skydio
pushed a commit
to eric-skydio/streamlit
that referenced
this pull request
Dec 20, 2023
* Update button height * Update unit test * Remove snapshots to regenerate them * Add regenerated snapshots * Remove unrelated snapshots with small diff failures * Remove light snapshots as well * Remove most of label_markdown snapshots, since they still have really small differences * Remove some snapshots, add others * Other snapshots deleted, new ones added * Add date_input snapshots, remove map ones * Add back map specs
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Mar 22, 2024
* Update button height * Update unit test * Remove snapshots to regenerate them * Add regenerated snapshots * Remove unrelated snapshots with small diff failures * Remove light snapshots as well * Remove most of label_markdown snapshots, since they still have really small differences * Remove some snapshots, add others * Other snapshots deleted, new ones added * Add date_input snapshots, remove map ones * Add back map specs
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
* Update button height * Update unit test * Remove snapshots to regenerate them * Add regenerated snapshots * Remove unrelated snapshots with small diff failures * Remove light snapshots as well * Remove most of label_markdown snapshots, since they still have really small differences * Remove some snapshots, add others * Other snapshots deleted, new ones added * Add date_input snapshots, remove map ones * Add back map specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
This PR fixes an issue reported by @sfc-gh-tteixeira where
st.buttonare not as tall as the rest of our widgets.The design team will have a more broad discussion to determine the best course of action for fixing this mid-term (potentially making widgets and buttons smaller, or taller but with a more standard
heightvalue), but in the meantime, we wanted to send a quick fix to make the buttons match the rest of the widgets.What kind of change does this PR introduce?
🧠 Description of Changes
Updated the
minHeightvalue in<BaseButton>;Revised:
Current:
🧪 Testing Done
🌐 References
Does this depend on other work, documents, or tickets?
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.