Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies of component-lib #6830

Merged
merged 1 commit into from Jun 14, 2023
Merged

Conversation

sfc-gh-kbregula
Copy link
Contributor

@sfc-gh-kbregula sfc-gh-kbregula commented Jun 13, 2023

Describe your changes

I had two PRs. #6584 depended on #6580 After merging the first PR, the head branch should update automatically to develop, but it didn't so I merged a second PR to merged branch. To fix it, I creating a new PR that targets to develop branch.


In this PR, I did the following changes:

  • I update apache-arrow and Typescript, which allowed us to remove the workaround and made this project compatible with newer versions of Typescript.
  • I also had to drop event-target-shim dependency which had a problem with the new version of Typescript, and it seems redundant now as browsers support this functionality natively.
  • I also updated the tests where necessary to add support for the new Typescript version.
  • Thanks to the new version of Typescript, the problems with compiling the project is gone. The npm run build command works. Tests are now run on CI and also the project is built to detect build issues sooner.

GitHub Issue Link (if applicable)

Testing Plan

  • Updated unit tests
  • QA review passed

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@sfc-gh-kbregula sfc-gh-kbregula merged commit 21e7bee into develop Jun 14, 2023
52 of 58 checks passed
tconkling added a commit to tconkling/streamlit that referenced this pull request Jun 14, 2023
* develop:
  Bump dependencies of component-lib (streamlit#6830)
  Make `streamlit config show` honor newlines (streamlit#6758)
  Update comments on magic.py (streamlit#6833)
  Add tests for component-lib (streamlit#6580)
  Fix button height (streamlit#6738)
  Add `to_pandas` method to convert inputs to pandas DataFrames (streamlit#6668)
  hash_funcs for st.cache_data and st.cache_resource (streamlit#6502)
@sfc-gh-kmcgrady sfc-gh-kmcgrady deleted the component-lib-modernize branch October 5, 2023 19:31
eric-skydio pushed a commit to eric-skydio/streamlit that referenced this pull request Dec 20, 2023
zyxue pushed a commit to zyxue/streamlit that referenced this pull request Mar 22, 2024
zyxue pushed a commit to zyxue/streamlit that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants