Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore iframe resizer anchor for apps with st.chat_input #6992

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Ignore iframe resizer anchor for apps with st.chat_input #6992

merged 3 commits into from
Jul 13, 2023

Conversation

LukasMasuch
Copy link
Collaborator

@LukasMasuch LukasMasuch commented Jul 12, 2023 •
edited

Describe your changes

The iframe resizer feature does not work well with apps with a bottom pinned st.chat_input. As a quick fix, we don't add the iframe resizer if the app contains a chat_input.

Note
This is likely more of a temporary quick fix. I'm planning to eventually do a refactoring of some of these aspects as part of the chat follow-up work (tracked here) to 1) handle those special cases better 2) support chat input usage in the sidebar and inline in app. 3) potentially moving it to it's own bottom root container.

Testing Plan

  • Added e2e test to check that iframe resizer anchor does not exist on page.

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@LukasMasuch LukasMasuch marked this pull request as ready for review July 12, 2023 15:57
@chakku000 chakku000 mentioned this pull request Jul 12, 2023
Merged
@LukasMasuch LukasMasuch merged commit 18dfe64 into develop Jul 13, 2023
48 checks passed
@mayagbarnes mayagbarnes mentioned this pull request Aug 31, 2023
Closed
5 tasks
@vdonato vdonato deleted the fix/chat-input-with-iframe-resizer branch November 1, 2023 23:57
eric-skydio pushed a commit to eric-skydio/streamlit that referenced this pull request Dec 20, 2023
@LukasMasuch @eric-skydio
Ignore iframe resizer anchor for apps with st.chat_input (streamlit…
016922e 
…#6992)

* Ignore resizer anchor for apps with chat_input

* Add e2e test

* Fix comment
zyxue pushed a commit to zyxue/streamlit that referenced this pull request Mar 22, 2024
@LukasMasuch
Ignore iframe resizer anchor for apps with st.chat_input (streamlit…
584d8f6 
…#6992)

* Ignore resizer anchor for apps with chat_input

* Add e2e test

* Fix comment
zyxue pushed a commit to zyxue/streamlit that referenced this pull request Apr 16, 2024
@LukasMasuch @zyxue
Ignore iframe resizer anchor for apps with st.chat_input (streamlit…
1c8aed3 
…#6992)

* Ignore resizer anchor for apps with chat_input

* Add e2e test

* Fix comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmcgrady kmcgrady kmcgrady approved these changes

Assignees
No one assigned
Labels
change:bugfix impact:internal security-assessment-completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LukasMasuch @kmcgrady