ignore Enter on inputing with IME #6993
Merged
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chakku000
force-pushed
the
ignore_enter_on_compositon
branch
from
10e756d
to
b5d5b03
Compare
vdonato
reviewed
Jul 14, 2023
vdonato
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Thanks for the contribution @chakku000!
This LGTM, but I'll also wait for @LukasMasuch to take a look as the resident expert on the st.chat_input widget. I don't think there are any unwanted side effects that this change can cause, but just being safe.
vdonato
reviewed
Jul 14, 2023
for test sets widget value when ⌘+enter
|
LGTM as well 👍 It feels like there could be some corner cases that this change might break, but I couldn't find anything. But we should monitor this after release if anyone complains about the |
|
Thank you for your reviews |
5 tasks
4 tasks
eric-skydio
pushed a commit
to eric-skydio/streamlit
that referenced
this pull request
Dec 20, 2023
…6993) * ignore Enter on composition for Japanese * fix incorrect indent num * write comment why uncapture Enter with isComposing * case of the lack of no nativeEvent or isComposing for test sets widget value when ⌘+enter
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Mar 22, 2024
…6993) * ignore Enter on composition for Japanese * fix incorrect indent num * write comment why uncapture Enter with isComposing * case of the lack of no nativeEvent or isComposing for test sets widget value when ⌘+enter
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
…6993) * ignore Enter on composition for Japanese * fix incorrect indent num * write comment why uncapture Enter with isComposing * case of the lack of no nativeEvent or isComposing for test sets widget value when ⌘+enter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
When the user types Japanese or Chinese with IME, we use "Enter" not only to send but also to confirm the character conversion.
If the application captures the "composing Enter" event as send text, it's awkward, because it results in sending even though we're still inputing the words.
This seems to be a common problem. See the follow issue on React.
#6992
For example, when I want to input the sentence in Japanese "私(watashi)は(ha)人(hito)です(desu)" , I press the following keys.
"watashi<convert_key>hahito<convert_key>desu"
As a result, the first is captured, and just "私(watashi)" is sent as a message.
To solve this problem, I found the
isComposingfield in nativeEvent, and I found that ignoring theisComposingevent gave me comfortable input.https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/isComposing
GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.