-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring: Remove an unnecessary form field sessionId
from the file upload client
#7980
Refactoring: Remove an unnecessary form field sessionId
from the file upload client
#7980
Conversation
Also, the
Can it also be removed, or may not if it's used in another proprietary implementation of the StreamlitEndpoints interface?
(The sessionId info is already embedded in the streamlit/frontend/app/src/App.tsx Line 1626 in c31f8b3
|
@kajarenc I believe we can remove this, or? |
Hey, @whitphx thanks for opening this PR! let me think about this a little bit, I will be back next week! |
@whitphx the test here needs to be adapted for the CI to run through:
|
@lukasmasuch Oops, missed it. but the E2E test failed... 🤔 |
@whitphx This is not on you :) The newest pandas release (2.2.0) is causing some issues in our CI pipeline. |
@whitphx Just needs another merge with |
@lukasmasuch Merged it 👍 |
LGTM 👍 Than you @whitphx! FOR |
@kajarenc Thanks! |
…le upload client (streamlit#7980) This sessionId field is no longer used in the server-side UploadFileRequestHandler.put(), which actually looks at the path params instead * Remove an unnecessary form field `sessionId` from the file upload client * Fix DefaultStreamlitEndpoints.test.ts
…le upload client (streamlit#7980) This sessionId field is no longer used in the server-side UploadFileRequestHandler.put(), which actually looks at the path params instead * Remove an unnecessary form field `sessionId` from the file upload client * Fix DefaultStreamlitEndpoints.test.ts
…le upload client (streamlit#7980) This sessionId field is no longer used in the server-side UploadFileRequestHandler.put(), which actually looks at the path params instead * Remove an unnecessary form field `sessionId` from the file upload client * Fix DefaultStreamlitEndpoints.test.ts
Describe your changes
This
sessionId
field is no longer used in the server-sideUploadFileRequestHandler.put()
, which actually looks at the path params instead:streamlit/lib/streamlit/web/server/upload_file_request_handler.py
Lines 84 to 91 in c31f8b3
Context: whitphx#7 (comment)
GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.