Refactoring: Remove an unnecessary form field sessionId from the file upload client

[whitphx]

Describe your changes

This sessionId field is no longer used in the server-side UploadFileRequestHandler.put(), which actually looks at the path params instead:

streamlit/lib/streamlit/web/server/upload_file_request_handler.py

Lines 84 to 91 in c31f8b3

	def put(self, **kwargs):
	"""Receive an uploaded file and add it to our UploadedFileManager."""
	args: Dict[str, List[bytes]] = {}
	files: Dict[str, List[Any]] = {}
	session_id = self.path_kwargs["session_id"]
	file_id = self.path_kwargs["file_id"]

Context: whitphx#7 (comment)

GitHub Issue Link (if applicable)

Testing Plan

• Explanation of why no additional tests are needed
• Unit Tests (JS and/or Python)
• E2E Tests
• Any manual testing needed?

---

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

[whitphx]

Also, the sessionId argument of uploadFileUploaderFile is no longer used if this PR is merged.

streamlit/frontend/app/src/connection/DefaultStreamlitEndpoints.ts

Line 115 in c31f8b3

sessionId: string,

Can it also be removed, or may not if it's used in another proprietary implementation of the StreamlitEndpoints interface?

(The sessionId info is already embedded in the fileUploadUrl beforehand here:

streamlit/frontend/app/src/App.tsx

Line 1626 in c31f8b3

sessionId: this.sessionInfo.current.sessionId,

)

[LukasMasuch]

@kajarenc I believe we can remove this, or?

[kajarenc]

Hey, @whitphx thanks for opening this PR!

let me think about this a little bit, I will be back next week!

[LukasMasuch]

@whitphx the test here needs to be adapted for the CI to run through:

streamlit/frontend/app/src/connection/DefaultStreamlitEndpoints.test.ts

Line 194 in c31f8b3

expectedData.append("sessionId", "mockSessionId")

[whitphx]

@LukasMasuch Oops, missed it.
I pushed the fix now.

but the E2E test failed... 🤔

[LukasMasuch]

@whitphx This is not on you :) The newest pandas release (2.2.0) is causing some issues in our CI pipeline.

[LukasMasuch]

@whitphx Just needs another merge with develop to get the CI to succeed.

[whitphx]

@LukasMasuch Merged it 👍

[kajarenc]

LGTM 👍 Than you @whitphx!

FOR uploadFileUploaderFile function signature, let's keep session_id there, we could come back to this, but for now, I wouldn’t want to change the interface of StreamlitEndpoints.

[whitphx]

@kajarenc Thanks!