Add command topic Deduplication(#246) #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- pulsarctl topics get-deduplication [topic] - pulsarctl topics set-deduplication [topic] -e - pulsarctl topics remove-deduplication [topic]
zymap
requested changes
Aug 2, 2021
| admin := cmdutils.NewPulsarClient() | ||
| err = admin.Topics().SetDeduplicationStatus(*topic, enable) | ||
| if err == nil { | ||
| vc.Command.Printf("Set the deduplication policy successfully for [%s]\n", topic.String()) |
There was a problem hiding this comment.
Add the enable or disable in the output?
| var examples []cmdutils.Example | ||
| msg := cmdutils.Example{ | ||
| Desc: "Set the deduplication policy for a topic", | ||
| Command: "pulsarctl topics set-deduplication topic ", |
There was a problem hiding this comment.
Add the enable and the disable examples?
| ) | ||
|
|
||
| func TestDeduplicationStatus(t *testing.T) { | ||
| topicName := "persistent://public/default/test-deduplication-status-topic" |
There was a problem hiding this comment.
Could you please add a random suffix on the topic name? You can use the test.RandomSuffix()
Signed-off-by: limingnihao <limingnihao@live.com>
zymap
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add command topic Deduplication: