-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PLATFORM-178] Metamask EIP 1102 Compatibility #126
Conversation
… null before the user gives permission to read the metamask account.
@fonty1 what is the easiest way to test this? |
@aapzu the link above will give you a chrome extension build. Before starting its easier if you export your previous metamask account so you don't have to recreate it on the new extension. Goto extensions, disable the old metamask, then toggle developer mode (top right), and then 'load unpacked' top left and build the extension you just downloaded. Once you have the new extension running, go into its settings and enable privacy mode. Then try and create a product or make a purchase. Metamask should popup a permission modal to accept so you can progress your purchase/tx. To retest, clear the privacy approval data in settings also. |
This is fun, another build release released 5hrs ago, they keep changing their minds so we might have to keep an eye on future builds 😅 |
👍 👍 👍 |
Metamask build to test with:
MetaMask/metamask-extension#4703 (comment)
Enable Privacy mode in Metamask settings to watch it fly.
Requesting permission to read the account information from the Metamask Provider, to be compliant with the upcoming breaking change coming from the Metamask extension.
Affects: Paid product creation & product purchasing.