Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLATFORM-178] Metamask EIP 1102 Compatibility #126

Merged
merged 4 commits into from
Nov 2, 2018

Conversation

fonty1
Copy link
Member

@fonty1 fonty1 commented Oct 31, 2018

Metamask build to test with:
MetaMask/metamask-extension#4703 (comment)

Enable Privacy mode in Metamask settings to watch it fly.

Requesting permission to read the account information from the Metamask Provider, to be compliant with the upcoming breaking change coming from the Metamask extension.

Affects: Paid product creation & product purchasing.

@fonty1 fonty1 requested review from tumppi and aapzu October 31, 2018 13:32
@aapzu
Copy link
Contributor

aapzu commented Oct 31, 2018

@fonty1 what is the easiest way to test this?

@fonty1
Copy link
Member Author

fonty1 commented Oct 31, 2018

@aapzu the link above will give you a chrome extension build.

Before starting its easier if you export your previous metamask account so you don't have to recreate it on the new extension.

Goto extensions, disable the old metamask, then toggle developer mode (top right), and then 'load unpacked' top left and build the extension you just downloaded.

Once you have the new extension running, go into its settings and enable privacy mode. Then try and create a product or make a purchase. Metamask should popup a permission modal to accept so you can progress your purchase/tx.

To retest, clear the privacy approval data in settings also.

@fonty1
Copy link
Member Author

fonty1 commented Oct 31, 2018

This is fun, another build release released 5hrs ago, they keep changing their minds so we might have to keep an eye on future builds 😅
https://68419-42009758-gh.circle-artifacts.com/0/builds/metamask-chrome-4.16.0.zip
@aapzu

app/src/marketplace/containers/WithWeb3/index.jsx Outdated Show resolved Hide resolved
app/src/marketplace/containers/WithWeb3/index.jsx Outdated Show resolved Hide resolved
app/src/marketplace/containers/WithWeb3/index.jsx Outdated Show resolved Hide resolved
app/src/marketplace/containers/WithWeb3/index.jsx Outdated Show resolved Hide resolved
app/src/marketplace/containers/WithWeb3/index.jsx Outdated Show resolved Hide resolved
@timoxley
Copy link
Contributor

timoxley commented Nov 2, 2018

👍 👍 👍

@fonty1 fonty1 merged commit 375714b into development Nov 2, 2018
@fonty1 fonty1 deleted the PLATFORM-178-metamask-eip-1102 branch November 2, 2018 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants