Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow 3 named types to be used as root schemas #80

Closed
Strech opened this issue Apr 4, 2021 · 0 comments · Fixed by #85
Closed

Allow 3 named types to be used as root schemas #80

Strech opened this issue Apr 4, 2021 · 0 comments · Fixed by #85
Labels
client API Anything related to the client API and its quality enhancement Improvement of existing functionality or request of improvement internal API Anything related to the internal API and implementations

Comments

@Strech
Copy link
Owner

Strech commented Apr 4, 2021

https://avro.apache.org/docs/current/spec.html#names

Record, enums and fixed are named types. Each has a fullname that is composed of two parts; a name and a namespace. Equality of names is defined on the fullname.

Currently, Encoder (and Codes.<...>) have the guards for encoding to be just map() which is wrong for Enum and Fixed.
@Strech Strech added enhancement Improvement of existing functionality or request of improvement client API Anything related to the client API and its quality internal API Anything related to the internal API and implementations labels Apr 4, 2021
@Strech Strech mentioned this issue Apr 4, 2021
Closed
@Strech Strech mentioned this issue Jun 1, 2021
Merged
@Strech Strech closed this as completed in #85 Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client API Anything related to the client API and its quality enhancement Improvement of existing functionality or request of improvement internal API Anything related to the internal API and implementations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for Fixed and Enum named types Strech/avrora
1 participant
@Strech