Add postbox royal cypher quest (new)

[arrival-spring]

Making a new pull request as I wasn't confident fixing the extra commits on the other one (I clearly need to brush up on git).

Almost there now I think, just a couple of things from my side

I couldn't find a source for http://www.bechler.free-online.co.uk/gc/RoyalCyphers2.jpg that said anything about copyright.

Also I'm not quite happy with saying "Just a crown" and it being tagged with "scottish_crown". "crown" has only been used twice per taginfo, so we shouldn't introduce that. Maybe only show that option in Scotland?

Fixes #2563

[westnordost]

I couldn't find a source for http://www.bechler.free-online.co.uk/gc/RoyalCyphers2.jpg that said anything about copyright.

I'd say don't worry about that. The cypher is not copyrighted by whoever created that bitmap, it is just a copy as well.

[westnordost]

Also I'm not quite happy with saying "Just a crown" and it being tagged with "scottish_crown". "crown" has only been used twice per taginfo, so we shouldn't introduce that. Maybe only show that option in Scotland?

Ok, well since it now shows a very detailed illustration of the scottish crown, I guess it is ok to label it that way too

[smichel17]

Making a new pull request as I wasn't confident fixing the extra commits on the other one (I clearly need to brush up on git).

I'm willing to help clean up the commits in the other one. I haven't been following it though, so I'll need you to point out what the problems are / which commits you want to keep or get rid of.

[arrival-spring]

I couldn't find a source for http://www.bechler.free-online.co.uk/gc/RoyalCyphers2.jpg that said anything about copyright.

I'd say don't worry about that. The cypher is not copyrighted by whoever created that bitmap, it is just a copy as well.

Ok, I'll just leave the licence column blank and just have the link then.

[arrival-spring]

Ok, well since it now shows a very detailed illustration of the scottish crown, I guess it is ok to label it that way too

Cool, I'll change that

[arrival-spring]

Making a new pull request as I wasn't confident fixing the extra commits on the other one (I clearly need to brush up on git).

I'm willing to help clean up the commits in the other one. I haven't been following it though, so I'll need you to point out what the problems are / which commits you want to keep or get rid of.

Thanks for the offer, don't know if it's needed though?

[westnordost]

I made the colors a bit lighter because one needs to think of night mode as well. I also made the stroke widths and colors consistent.
I also cleaned up the source SVGs and simplified them a bit, especially the crown of scotland had a lot of garbage in there (1.2 MB -> 12 KB) but the others were also quite large.

I also reordered the items by prevalence.

Finally, I stumbled upon this article: https://historianruby.com/2018/04/01/royal-ciphers-on-postboxes-a-brief-guide/
...and noticed that sometimes only the abbreviation is displayed on the postbox, not always the cypher. See the pictures for "VR". So I think to avoid confusion, the abbreviations need to be added as a label. But I added them as "untranslatable strings"

[arrival-spring]

That all makes sense, thanks for that, it all looks nice and neat now.
My choice of colour red was just based on a search for post box red, but this is still a good colour.

[arrival-spring]

The other thing I thought of is that when you select none from more answers, it immediately adds that tag, and perhaps that's inconsistent with other quests where none is an option (like no name, no max weight/height).

[westnordost]

Ah right, maybe that should be changed. A generic "are you sure" dialog would be enough Am 17. Februar 2021 11:58:51 MEZ schrieb arrival-spring <notifications@github.com>:

…

The other thing I thought of is that when you select none from more answers, it immediately adds that tag, and perhaps that's inconsistent with other quests where none is an option (like no name, no max weight/height). -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #2583 (comment)

-- Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.

[arrival-spring]

Ah right, maybe that should be changed. A generic "are you sure" dialog would be enough

Makes sense, done

[peternewman]

Is it worth adding royal_cypher:wikidata at the same time given we know it too?

[westnordost]

No

[arrival-spring]

Is it worth adding royal_cypher:wikidata at the same time given we know it too?

This was discussed here:
#2576 (comment)

[peternewman]

Is it worth adding royal_cypher:wikidata at the same time given we know it too?

This was discussed here:
#2576 (comment)

Ah thanks @arrival-spring . I hadn't really looked at the old PR.

[westnordost]

For your information, from the OSM slack channel #streetcomplete:

The video linked is https://www.youtube.com/watch?v=3FBIwugbkqA

---

Of course, this is not a requirement for merging this PR, the PR is already approved. This is just FYI. This could also be done by another person who is interested in it in Ireland (later), or not at all, if there is not interest.

[arrival-spring]

Might have a look, is there another quest which has different answers in different countries?

[westnordost]

Yes, f.e. AddRecyclingContainerMaterialsForm. You can check the country code for example by querying countryInfo.countryCode

[TurnrDev]

This is looking good! Excited for this one!

[westnordost]

Chris Andrew wrote me an email:

Great postbox additional, in the latest release. I haven't checked out the other features, yet.

Well done

Chris.

[arrival-spring]

Thanks for the feedback, that's great

[pigsonthewing]

Thank you for this.

Any version for Ireland should include the logo seen in: https://commons.wikimedia.org/wiki/File:Irish_post_box.jpg

[pigsonthewing]

Maybe also useful in Gibraltar: https://commons.wikimedia.org/wiki/Category:Red_post_boxes_in_Gibraltar

[TurnrDev]

Maybe also useful in Gibraltar: https://commons.wikimedia.org/wiki/Category:Red_post_boxes_in_Gibraltar

Oh yeah not sure why I forgot to mention this

[westnordost]

And the crown dependencies and overseas territories?

[TurnrDev]

Yeah, Falkland Islands has them too. I'll try do some research and add a PR for it.

[matkoniecz]

Is it intentional that it was added to rare quest achievements? It will be asked for every single post box in UK.

[arrival-spring]

Is it intentional that it was added to rare quest achievements? It will be asked for every single post box in UK.

Discussion was here.

[FloEdelmann]

See also #2675 (comment)

[westnordost]

I have no strong feelings on this.

[matkoniecz]

I feel that it should be removed, but if someone will protest will not do this.

[arrival-spring]

I don't particularly mind, it depends how rare you want 'rare' to be. Although there are lots of post boxes in general, they're fairly spread out, but I agree this is less rare than the other 'rare' quests.

[TurnrDev]

I wouldn't consider this rare at all. In time areas near me, every other road has a postbox.

[peternewman]

Is it intentional that it was added to rare quest achievements? It will be asked for every single post box in UK.

It will only be asked for the ones where it hasn't already been gathered, which based on this is about half of them (40k):
https://osm.mathmos.net/postboxes/osm-royal-cypher.html

I'd say it's a bit less rare than AddWheelchairAccessToiletsPart, nothing is going to match AddSummitRegister or AddFerryAccess* though.

FWIW according to the stats (which for some reason, possibly undo's) don't match my * count, I've done three rare quests across 13,000+ total. Looking at my history, I did three Royal Cyphers in one changeset last week! So not very rare, although toilets does seem similar.

[matkoniecz]

Committed removal with following commit description:

remove AddPostBoxRoyalCypher from rare quests

available for about half of postboxes, as long as you are in UK they are not hidden, it does not require enabling quest unlike wheelchair ones or in locations where SC use is unusual
if you feel strongly about it feel free to revert

[timothywashere]

I've made a couple of mistakes with this quest and think maybe a slight clarification might be needed.

The EVIIR cypher is very elobrate but on smaller Wall boxes they used a simpler text version instead E VII R

When spotting this cypher it is easy to select the answer for EVIIIR instead, which looks the most like the text version of EVIIR.

EVIIIR is very rare due to his length of reign being months.

It might be a good idea if there was a confirmation dialogue when trying to select EVIIIR to prevent idiots like me selecting the wrong one.

Elaborate and simple EVIIR:
http://www.oxfordhistory.org.uk/streets/post_boxes/edward_vii/index.html

Relatively simple EVIIIR
https://en.wikipedia.org/wiki/Pillar_box#/media/File:E8R_Door.jpg

[matkoniecz]

@timothywashere If you think that it is issue that should be fixed it would be better to open a new issue via https://github.com/streetcomplete/StreetComplete/issues/new/choose

Comment on a closed PR is likely to be missed/forgotten.

(I am not familiar with mapping this or this specific quest so I am unable to judge this idea well)

[westnordost]

RIP EIIR. Time for a CIIIR? A PR is welcome, as soon as the new cypher is official.

[timothywashere]

I'll keep an eye out, but they don't place many new postboxes these days, they probably remove more. Maybe a large new housing estate might get one

[pigsonthewing]

Time for a CIIIR? A PR is welcome, as soon as the new cypher is official.

It's almost certain there will be no new cypher for a while; probably until the coronation Then there is likely to be a promotional installation (or a small set, like one in each national capital) to launch the new cypher.

[TurnrDev]

I'll keep an eye out, but they don't place many new postboxes these days, they probably remove more. Maybe a large new housing estate might get one

Plus the occasional supermarket

[timothywashere]

The cypher has been revealed
https://www.bbc.co.uk/news/uk-63034255

[FloEdelmann]

Let's continue this thread in #4420.

[osm-spiregrain]

Let's continue this thread in #4420.

Hah - we must have been keying it in simultaneously!