Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smarter text search in tag features search - at least trailing spaces should not remove matches #2971

Closed
matkoniecz opened this issue Jun 17, 2021 · 3 comments

Comments

@matkoniecz
Copy link
Member

Use case
Make easier to find features when replacing gone shops

Note: it may belong rather in https://github.com/westnordost/osmfeatures

To reproduce, with English as language:

find name/opening hours/etc quest
select "can't say" -> "it does not exist"
place typing cursor in "A(n)"
type "boutique" - works as expected, sows relevant matches
press space - does not work as expected, matches are lost

As bonus: "boutique foobar" should also match terms produced by "boutique". Writing also shop name is not expected but some users will do it anyway: https://www.openstreetmap.org/note/2521421 ("Wpisałem chyba butik i nazwę" - "I probably wrote boutique and its name").

@westnordost
Copy link
Member

.trim()

@matkoniecz
Copy link
Member Author

I though about splitting on space and searching also each word separately, to support case of someone writing multiple words, with one matching.

@westnordost
Copy link
Member

Nah. Because there can well be presets that consist of several words.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants