Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ask also about living streets' sidewalk surface, if there is a sidewalk #4424

Closed
legofahrrad opened this issue Sep 28, 2022 · 6 comments · Fixed by #4429
Closed

ask also about living streets' sidewalk surface, if there is a sidewalk #4424

legofahrrad opened this issue Sep 28, 2022 · 6 comments · Fixed by #4429

Comments

@legofahrrad
Copy link
Contributor

highway ~ motorway|motorway_link|trunk|trunk_link|primary|primary_link|secondary|secondary_link|tertiary|tertiary_link|unclassified|residential

There are more than 9,600 ways which are highway=living_street with sidewalk=both|left|right (see https://taginfo.openstreetmap.org/tags/highway=living_street#combinations)
The sidewalk surface quest should also appear on these living streets.


Maybe also add highway=service? (There are >37,600 ways tagged with highway=service and sidewalk=both|left|right; see https://taginfo.openstreetmap.org/tags/highway=service#combinations)

@westnordost
Copy link
Member

Sure, if there is a sidewalk, it is valid to ask the surface for. Will you open a PR for that?

@legofahrrad
Copy link
Contributor Author

Will you open a PR for that?

Sorry, I wanna keep in my comfort zone ;)
Yeah, it's just one line of code – but

  • downloading Android Studio
  • forking StreetComplete
  • what else have you to do to create a Pull Request? 😅

You can do it in seconds, can't you? @westnordost ;)

@westnordost
Copy link
Member

You can edit it online:

image

@legofahrrad
Copy link
Contributor Author

Oof, never knew this! Thanks, then I'll give it a try at the weekend :)

@mcliquid
Copy link
Contributor

@legofahrrad I don't want to take the helm here, but I was just in the project anyway. I'll be happy to let you make the change if you want to do. Then I take the PR back again.

@HolgerJeromin
Copy link
Contributor

You can edit it online

In the fork (done by github automagically) you can trigger a build. So you can download an apk in the phone and test your changes without installing anything on your computer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants