Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocorrect: use title-case instead of upper-case #4785

Merged

Conversation

balsoft
Copy link
Contributor

@balsoft balsoft commented Jan 31, 2023

In some languages, title-case for letters is different from upper-case. This difference is captured by the titlecase function in Kotlin. Use it instead of uppercase.

Fixes #4784

@matkoniecz
Copy link
Member

You may be able to trigger build at https://github.com/balsoft/StreetComplete/actions

@balsoft
Copy link
Contributor Author

balsoft commented Jan 31, 2023

Thanks! Seems like I can run the workflow, but it doesn't appear to be attached to the commit in this repo.

@balsoft
Copy link
Contributor Author

balsoft commented Jan 31, 2023

Looks like the build succeeds and the resulting APK exhibits the correct behavior:

23-02-01-00-56-48.mp4

@westnordost westnordost merged commit afed967 into streetcomplete:master Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Street names are automatically title-cased in locales where they shouldn't be
3 participants