Skip to content

Commit

Permalink
Fix for issue 72?
Browse files Browse the repository at this point in the history
Call me crazy, but if this is return false, this function will always return false, since emptyBucket defaults to true, and therefore the call to set emptyBucket to false will never execute?
  • Loading branch information
streetlogics committed Dec 10, 2013
1 parent 76f3299 commit 5f75324
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion methods/realtime-candle-fetcher.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ CandleCalculator.prototype.fillBuckets = function(trades) {
// it should go to the next bucket
while(time > nextBucketTime) {
if(emptyBucket === true)
return false;
break;

// we can calculate the candle of the freshly filled bucket
this.calculateCandle();
Expand Down

1 comment on commit 5f75324

@Devouring
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this fix and it works !!
Thanks a lot ^^

Please sign in to comment.