Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add People Names dictionary. #3276

Merged
merged 4 commits into from
Jun 10, 2024
Merged

feat: Add People Names dictionary. #3276

merged 4 commits into from
Jun 10, 2024

Conversation

Jason3S
Copy link
Collaborator

@Jason3S Jason3S commented Jun 8, 2024

fixes #3236

Checklist

  • By submitting this pull-request, you agree to follow our Code of Conduct
  • Verify that the title starts with the correct prefix:
    • fix: - for minor changes like adding words or fixing spelling issues.
    • feat: - for a significant change like adding a whole new set of words to a dictionary.
    • feat!: - for breaking changes, like file format or licensing changes.
    • chore: - for changes that do not impact the content of dictionaries.

Copy link
Sponsor Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the dictionary Jason!

I have a couple of minor comments:

dictionaries/people-names/README.md Outdated Show resolved Hide resolved
dictionaries/people-names/README.md Outdated Show resolved Hide resolved
dictionaries/people-names/cspell-ext.json Show resolved Hide resolved
dictionaries/people-names/README.md Show resolved Hide resolved
dictionaries/people-names/README.md Show resolved Hide resolved
dictionaries/people-names/src/names.txt Show resolved Hide resolved
dictionaries/people-names/src/names.txt Outdated Show resolved Hide resolved
Jason3S and others added 2 commits June 9, 2024 20:59
Co-authored-by: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com>
@Jason3S
Copy link
Collaborator Author

Jason3S commented Jun 10, 2024

@arkid15r and @ccoVeille,

I'm going to land this PR. Please feel free to open PRs for edits.

@Jason3S Jason3S merged commit a28300b into main Jun 10, 2024
9 checks passed
@Jason3S Jason3S deleted the dev-names branch June 10, 2024 11:58
This was referenced Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A new dictionary: first name, last name items
3 participants