Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

domain field not correctly set ? #24

Closed
c-x opened this issue Jun 2, 2013 · 1 comment
Closed

domain field not correctly set ? #24

c-x opened this issue Jun 2, 2013 · 1 comment

Comments

@c-x
Copy link
Contributor

c-x commented Jun 2, 2013

The 2 following command lines are supposed to produce the same output except for the subdomain part (none for the first one, "aaaa" for the second).

./faup -o json http://mmtro.com/tro.js
./faup -o json http://aaaa.mmtro.com/tro.js

However the output differ and the "domain" field is not correctly set in the first case (host field is ok). In this particular case, the host and the domain are the same.

# ./faup -o json http://mmtro.com/tro.js
{
        "scheme": "http",
        "credential": "",
        "subdomain": "",
        "domain": "",
        "host": "mmtro.com",
        "tld": "com",
        "port": "",
        "resource_path": "/tro.js",
        "query_string": "",
        "fragment": "",

}
#./faup -o json http://aaaa.mmtro.com/tro.js
{
        "scheme": "http",
        "credential": "",
        "subdomain": "aaaa",
        "domain": "mmtro.com",
        "host": "aaaa.mmtro.com",
        "tld": "com",
        "port": "",
        "resource_path": "/tro.js",
        "query_string": "",
        "fragment": "",
}

Should Faup duplicate the host into the domain field ?

@stricaud
Copy link
Owner

stricaud commented Jun 2, 2013

Thanks for the report, this is a real bug that needs to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants