Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strider build 'undefined' branch when tag is pushed #74

Closed
BluSyn opened this issue Oct 25, 2016 · 4 comments
Closed

Strider build 'undefined' branch when tag is pushed #74

BluSyn opened this issue Oct 25, 2016 · 4 comments

Comments

@BluSyn
Copy link

BluSyn commented Oct 25, 2016

Recent strider + plugin upgrade caused this error. Have not yet determined what caused the breaking change.

When I push a new tag to my repo, strider attempts to build it, but <%= ref.branch %> returns undefined. Previously, strider would only build on branch pushes and not on new tags.

It's also possible this was a change in Github's webooks, but I haven't confirmed that. I tried disabling the 'Create' webhook event (Only 'Pull Request' and 'Push' options set), and it still sends a webhook and attempts to build it.

Note: This is causing some havoc with my build scripts, which expect a valid branch name. I've had to add checks for undefined branch in all build scripts so it doesn't cause deployment problems.

screen shot 2016-10-25 at 11 35 30 am

screen shot 2016-10-25 at 11 35 49 am

@knownasilya
Copy link
Member

Weird, I've experienced the opposite. In the past it would build on tag, but recently (with latest updated) it hasn't triggered on tags.

@BluSyn
Copy link
Author

BluSyn commented Oct 25, 2016

Strange. That's the problem I would prefer to have ;)

I usually push a tag+branch at the same time, and I don't recall it building twice in that case. Now it creates two builds: one with branch name, one undefined.

Version info-
Strider v1.9.3
strider-github v2.3.2

Screenshot shows how it looks in build history (tag+branch push):
screen shot 2016-10-25 at 12 02 25 pm

@anddimario
Copy link

I'm trying to use tags or release to trigger customs script, but triggers seems that are not fired. I saw that branch is undefined when hook is grabbed from strider, maybe it could be the problem. Have you some suggestions on this problem?

@BluSyn
Copy link
Author

BluSyn commented Feb 3, 2017

It appears this is fixed now. I think it was an issue with Github sending improper/multiple webhooks, and strider interpreting it incorrectly. I do not see this issue now.

@BluSyn BluSyn closed this as completed Feb 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants