-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an endpoint to display the bridge version. #375
Comments
We already expose the OpenAPI specification on the
The problem with the first solution is about having the OpenAPI spec files aligned with the version we are releasing (maybe we should automate "something" via make), while the second solution is fully dynamic. |
Hi, Regarding the openapi spec approach, I have a related question. I wanted to use a template file and inject other values (e.g., for basePath) so that when it is hosted behind a gateway, we could inject the correct basePath when the gateway is passing x-forwarded-prefix header to the bridge host. If we take this approach, we can also inject the version into the document. |
@elakito but the openapi json file is a resource so what you said should happen at compile time when building the jar. So if you want to change the |
thinking more I would agree with @elakito about using the root |
Yes, probably it is a better idea to have this prepared for more info entries, not just version. |
it sounds good about using the root path to provide the bridge info. @ppatierno Regarding the I am currently using a small translation code at the gateway to do this adjustment and I thought it would be nice if it is done directly at the bridge. But I don't know if other people also want such a dynamic translation. |
@elakito can you move this to an issue for discussion, please? Thanks! |
Nowadays the Kafka bridge only displays its version in the startup. It would be nice to have an endpoint to display its version.
Let's suppose we have a new feature available only on versions > 0.13.0. With this /version endpoint a client can easily check if the version he is connecting matches the minimal version for that feature.
The text was updated successfully, but these errors were encountered: