AMEX CVC authentication

[mrmonopoly237]

The AMEX CVC authentication completes after the entry of the 3rd number.

[maccman]

3 digit Amex CVCs are valid. Amex CVCs can be 3 or 4 digits.

[mrmonopoly237]

Totally didn't know that, thank you.

However, it appears that the delegate call back on PKView only happens after the third digit is entered. If the user enters a 4th digit there is no call-back or indication that this has happened.

[sebbean]

3 digit amex's are valid - but stopping at the 3rd digit makes 4 digit amex' cvc's impossible to type in.

the keyboard is dismissed at the 3rd digit even if it's an amex (and could possibly have a 4th digit)

This is definitely still an open issue

[sebbean]

Also, are you sure AmEx currently issues cards with 3 digit codes?

Light googling returned:

http://www.cvvnumber.com/cvv.html

American Express® cardholders:
Look for the 4-digit code printed on the front of your card just above and to the right of your main credit card number. This 4-digit code is your Card Identification Number (CID). The CID is the four-digit code printed just above the Account Number.

[maccman]

However, it appears that the delegate call back on PKView only happens after the third digit is entered. If the user enters a 4th digit there is no call-back or indication that this has happened.

@michaelvillar ?

[sebbean]

this seems to fix it (in PKView.m ~line 266)

Sorry - new to pull-requests n what not, meant to do it that way.

- (BOOL)isValid
{    
    return [self.cardNumber isValid] && [self.cardExpiry isValid] &&
           [self.cardCVC isValidWithType:[[PKCardNumber cardNumberWithString:cardNumberField.text] cardType]];
}

[michaelvillar]

@sebbean AMEX have 3 digits code as well.

Here is the fix d6f9f94