Skip to content
This repository has been archived by the owner on Jul 30, 2021. It is now read-only.

Localization Resources not included in pod #33

Closed
azcoov opened this issue Feb 25, 2014 · 2 comments
Closed

Localization Resources not included in pod #33

azcoov opened this issue Feb 25, 2014 · 2 comments

Comments

@azcoov
Copy link

azcoov commented Feb 25, 2014

I noticed that the Localization is not being pulled down when installing from the podspec.

This results in the card view placeholder text to be literal. Example:

self.cardNumberField.placeholder = NSLocalizedStringFromTable(@"placeholder.card_number", @"STPaymentLocalizable", nil);

will display the placeholder.card_number in the placeholder.

I'm not comfortable enough with podspec files to correct this. I'm inclined to just include the entire resources folder because it has everything we need.

Also, this localization issue is a new change from this commit.

@loudnate
Copy link
Contributor

That's a good thing - you should create that table in your own bundle resources. What might be a good pull request would be to use NSLocalizedStringWithDefaultValue instead so that folks who don't care to add localization still get the EN defaults included in the repo.

@azcoov
Copy link
Author

azcoov commented Feb 26, 2014

Makes sense, thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants