Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix test cases to be compatible with mocha@6.x #2310

Merged
merged 1 commit into from
Jan 30, 2019
Merged

chore: fix test cases to be compatible with mocha@6.x #2310

merged 1 commit into from
Jan 30, 2019

Conversation

raymondfeng
Copy link
Contributor

@raymondfeng raymondfeng commented Jan 30, 2019 •
edited

See mochajs/mocha#3550

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

jannyHou
jannyHou approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@jannyHou jannyHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

b-admike
b-admike reviewed Jan 30, 2019
View reviewed changes
packages/rest/test/unit/rest.component.unit.ts
expect(result).to.deepEqual(expected.value());
});
}
it('', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we get a deprecation warning if we don't wrap this block of code with the empty it block?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It's also required to trigger before and run multiple tests in a loop.

@raymondfeng raymondfeng merged commit a4c2086 into master Jan 30, 2019
@bajtos bajtos deleted the fix-test-cases-for-mocha6 branch February 4, 2019 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannyHou jannyHou jannyHou approved these changes

@b-admike b-admike b-admike approved these changes

@bajtos bajtos Awaiting requested review from bajtos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raymondfeng @jannyHou @b-admike