chore: fix test cases to be compatible with mocha@6.x

See mochajs/mocha#3550
loopbackio · Jan 30, 2019 · a4c2086 · a4c2086
1 parent c601c4c
commit a4c2086
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 17 deletions.
diff --git a/packages/repository/test/unit/repositories/relation.repository.unit.ts b/packages/repository/test/unit/repositories/relation.repository.unit.ts
@@ -88,7 +88,7 @@ describe('relation repository', () => {
       });
     });
 
-    context('patch', async () => {
+    context('patch', () => {
       it('can patch related model instance', async () => {
         const constraint: Partial<Customer> = {name: 'Jane'};
         const hasManyCrudInstance = givenDefaultHasManyInstance(constraint);

diff --git a/packages/rest-explorer/test/acceptance/rest-explorer.acceptance.ts b/packages/rest-explorer/test/acceptance/rest-explorer.acceptance.ts
@@ -55,7 +55,7 @@ describe('API Explorer (acceptance)', () => {
     });
   });
 
-  context('with custom RestServerConfig', async () => {
+  context('with custom RestServerConfig', () => {
     it('honours custom OpenAPI path', async () => {
       await givenAppWithCustomRestConfig({
         openApiSpec: {

diff --git a/packages/rest/test/unit/coercion/paramStringToNumber.unit.ts b/packages/rest/test/unit/coercion/paramStringToNumber.unit.ts
@@ -56,7 +56,7 @@ describe('coerce param from string to number - required', () => {
 });
 
 describe('coerce param from string to number - optional', () => {
-  context('valid values', async () => {
+  context('valid values', () => {
     test(NUMBER_PARAM, '0', 0);
     test(NUMBER_PARAM, '1', 1);
     test(NUMBER_PARAM, '-1', -1);

diff --git a/packages/rest/test/unit/rest.component.unit.ts b/packages/rest/test/unit/rest.component.unit.ts
@@ -24,22 +24,30 @@ import {
 const SequenceActions = RestBindings.SequenceActions;
 describe('RestComponent', () => {
   describe('Providers', () => {
-    describe('Default implementations are bound', async () => {
-      const app = new Application();
-      app.component(RestComponent);
+    describe('Default implementations are bound', () => {
+      let app: Application;
+      let comp: Component;
 
-      // Stub constructor requirements for some providers.
-      app.bind(RestBindings.Http.CONTEXT).to(new Context());
-      app.bind(RestBindings.HANDLER).to(new HttpHandler(app));
+      before(async () => {
+        app = new Application();
+        app.component(RestComponent);
+
+        // Stub constructor requirements for some providers.
+        app.bind(RestBindings.Http.CONTEXT).to(new Context());
+        app.bind(RestBindings.HANDLER).to(new HttpHandler(app));
+
+        comp = await app.get<Component>('components.RestComponent');
+      });
 
-      const comp = await app.get<Component>('components.RestComponent');
-      for (const key in comp.providers || {}) {
-        it(key, async () => {
-          const result = await app.get(key);
-          const expected: Provider<BoundValue> = new comp.providers![key]();
-          expect(result).to.deepEqual(expected.value());
-        });
-      }
+      it('', async () => {
+        for (const key in comp.providers || {}) {
+          it(key, async () => {
+            const result = await app.get(key);
+            const expected: Provider<BoundValue> = new comp.providers![key]();
+            expect(result).to.deepEqual(expected.value());
+          });
+        }
+      });
     });
     describe('LOG_ERROR', () => {
       it('matches expected argument signature', async () => {