Include user in login result #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test FAILed. To trigger a build add comment - ".test\W+please" |
|
Note: there is one test failing, the failure was introduced by loopbackio/loopback-datasource-juggler@cf200a2. @raymondfeng Could you please investigate and fix the problem? |
|
The regression should be fixed by #164 |
added 2 commits
January 30, 2014 18:09
Add an explicit note that clients are not supposed to send the `access_token` parameter, since it is extracted from request headers.
Allow LB clients to get details of the currently logged-in user as part of the login response. Improve method's `description` to mention this new option.
|
Thank you @raymondfeng for fixing the regression quickly. I have rebased my commits on top of current master. |
|
Test PASSed. To trigger a build add comment - ".test\W+please" |
|
LGTM |
bajtos
added a commit
that referenced
this pull request
Jan 30, 2014
…-result Include user in login result
wdoug
added a commit
to codefordenver/encorelink
that referenced
this pull request
Nov 2, 2016
See strongloop/loopback#163 for context on how this works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is unrelated, it improves the ngdoc documentation generated by loopback-angular.
The second commit implements the necessary changes.
Close #161. See also #162.
/to: @ritch please review
/cc: @raymondfeng
/cc: @seanbrookes This change should simplify your iCars controllers, as you don't have to send two requests on login (
User.login,User.get).