Remove the generated flag for access token id #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated flag is used to indicate if the id is automatically generated by the backend store. If it's set, the data type will be updated when the model is attached to a datasource. The AccessToken model defines a string id, which is set in the beforeCreate hook. So it's client provided id.
|
LGTM. |
raymondfeng
added a commit
that referenced
this pull request
Jan 30, 2014
Remove the generated flag for access token id
|
Test PASSed. To trigger a build add comment - ".test\W+please" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated flag is used to indicate if the id is automatically generated
by the backend store. If it's set, the data type will be updated when the
model is attached to a datasource.
The AccessToken model defines a string id, which is set in the beforeCreate
hook. So it's client provided id.
/to @bajtos @ritch