Ensure stream:features have been received before consider them "processed" #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcbrand
added a commit
that referenced
this pull request
May 5, 2014
Ensure stream:features have been received before consider them "processed"
joachimlindborg
pushed a commit
to joachimlindborg/strophejs-plugins
that referenced
this pull request
May 13, 2015
Pull request [strophe#26](https://github.com/metajack/strophejs-plugins/pull/26/files) for fixing the XHTML support used `.h()` for attaching HTML message part. Without it, it doesn't work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found the issue working against Tigase server.
Tigase does not send the feature list on the first response after the connection, so the register plugin correctly calls "_no_auth_received" to send a "poll" request; however as the processed_features flag was being set, the register plugin never got to process the actual response with the features, and hence never registers the user.
With this change will ensure that the list was actually received before setting the flag.