Sends all presence messages to _presence_handlers #59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently any presence message that does not have
an ‘x’ tag does not get send to the
presence_handler. This means error messages such
as
<presence xmlns='jabber:client' type='error' to=‘xx’ from=‘xx/test'> <error type='cancel'> <not-allowed xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/> </error> </presence>
does not get passed to the handler. This results in
errors like this not being handled and client code
not knowing about it and instead assuming
everything is fine.
This commit removes the custom handling and passes
all presence messages to the handlers attached,
which is how the code has always worked in the case
of the message_handlers.
This way error handling can be implemented in the
presence_handlers, as how they are being done in
the message_handlers.