Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: better error message if react-scripts dependency cannot be found #1694

Merged
merged 10 commits into from
Sep 10, 2019
Merged

fix: better error message if react-scripts dependency cannot be found #1694

merged 10 commits into from
Sep 10, 2019

Conversation

marcelvdh
Copy link
Contributor

Fixes #1561

@marcelvdh marcelvdh closed this Sep 2, 2019
@marcelvdh marcelvdh reopened this Sep 2, 2019
@bartekleon
Copy link
Member

looks good to me, i dunno why it had error in E2E tho

@marcelvdh
Copy link
Contributor Author

@kmdrGroch

Thanks for your feedback.

Build Server output:

20:40:13 (7910) ERROR StrykerCli an error occurred Error: Error: MODULE_NOT_FOUND >(undefined) Error: Cannot find module '@angular/cli/package'

@bartekleon
Copy link
Member

@marcelvdh I saw it. Strange thing is that your previous build had passed, and in the next (where you changed only comments) didn't. So I assume it's just a one-time error.

@marcelvdh marcelvdh closed this Sep 3, 2019
@marcelvdh marcelvdh reopened this Sep 3, 2019
@marcelvdh
Copy link
Contributor Author

@marcelvdh I saw it. Strange thing is that your previous build had passed, and in the next (where you changed only comments) didn't. So I assume it's just a one-time error.

@kmdrGroch I started the build again it passed this time.

@nicojs
Copy link
Member

nicojs commented Sep 5, 2019

I've added tests for the new messages. Wil merge when green. Thanks @marcelvdh and @kmdrGroch

@bartekleon
Copy link
Member

@nicojs greeen! :D

@nicojs nicojs merged commit 313e3bf into stryker-mutator:master Sep 10, 2019
@nicojs
Copy link
Member

nicojs commented Sep 10, 2019

Awesome, thanks for the work @marcelvdh

@marcelvdh marcelvdh deleted the fix-1561 branch September 10, 2019 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartekleon bartekleon bartekleon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Could not inject "optionsFactory". Inner error: Cannot find module 'react-scripts/package.json'
3 participants
@marcelvdh @bartekleon @nicojs