Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(perf/angular-cli): upgrade to latest angular version and fix bugs #1842

Merged
merged 5 commits into from
Nov 13, 2019

Conversation

simondel
Copy link
Member

No description provided.

@simondel
Copy link
Member Author

Awesome, now we just have to revert the build change

@bartekleon
Copy link
Member

bartekleon commented Nov 12, 2019

Simon, could you btw please change all '^' into '~' in package.json?
and is corejs used at this point? I see you have removed all imports from polyfills

@simondel
Copy link
Member Author

Yeah, I will. The ng update command must have done that. Nice catch

@simondel
Copy link
Member Author

@kmdrGroch Done!

@bartekleon
Copy link
Member

Thanks @simondel ! But could you please rerun tests, since angular is not passing performance tests(?), It probably is false check but to be sure

@simondel simondel merged commit 4f81550 into master Nov 13, 2019
@simondel simondel deleted the fix-perf branch November 13, 2019 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants