feat(.gitignore): add Stryker patterns to .gitignore file during initialization #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicojs
requested changes
Nov 16, 2019
|
|
||
| public async addStrykerTempFolder() { | ||
| if (fsAsPromised.existsSync(GITIGNORE_FILE)) { | ||
| const strykerTempFolderSpecification = `${os.EOL}# stryker temp files${os.EOL}*.stryker-tmp${os.EOL}`; |
There was a problem hiding this comment.
Please define '.stryker-tmp' as a const to be reused (from @stryker-mutator/api/config), making it DRY
There was a problem hiding this comment.
Also: running stryker init multiple times will result in multiple rules being added to your .gitignore file. We can do a simple if(!gitignoreContent.endswith(strykerTempFolderSpecification) to prevent this. Not really necessary maybe, but nice none the less.
There was a problem hiding this comment.
Why *.stryker-tmp instead of .stryker-tmp?
| @@ -52,6 +53,7 @@ describe(StrykerInitializer.name, () => { | |||
| .provideClass(initializerTokens.npmClient, NpmClient) | |||
| .provideValue(initializerTokens.strykerPresets, presets) | |||
| .provideClass(initializerTokens.configWriter, StrykerConfigWriter) | |||
| .provideClass(initializerTokens.gitignoreWriter, GitignoreWriter) | |||
There was a problem hiding this comment.
I'm pretty sure this will result in the real one being included. Please use a mocked GitingoreWriter and test that it is called correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1683