Skip to content

Commit

Permalink
util: Added tsan annotate for thread name.
Browse files Browse the repository at this point in the history
This allows us to see the name of the thread in tsan
warning reports such as this:

  Thread T7 'CPU 1/TCG' (tid=24317, running) created by main thread at:

Signed-off-by: Robert Foley <robert.foley@linaro.org>
Reviewed-by: Emilio G. Cota <cota@braap.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20200609200738.445-12-robert.foley@linaro.org>
Message-Id: <20200612190237.30436-15-alex.bennee@linaro.org>
  • Loading branch information
Robert Foley authored and stsquad committed Jun 16, 2020
1 parent e51345e commit ce9f0e5
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions util/qemu-thread-posix.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
#include "qemu/atomic.h"
#include "qemu/notify.h"
#include "qemu-thread-common.h"
#include "qemu/tsan.h"

static bool name_threads;

Expand Down Expand Up @@ -513,6 +514,7 @@ static void *qemu_thread_start(void *args)
# endif
}
#endif
QEMU_TSAN_ANNOTATE_THREAD_NAME(qemu_thread_args->name);
g_free(qemu_thread_args->name);
g_free(qemu_thread_args);
pthread_cleanup_push(qemu_thread_atexit_notify, NULL);
Expand Down

0 comments on commit ce9f0e5

Please sign in to comment.