You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
👋 Hi! New contributor here. I'm updating the typing stubs for pytz in typeshed (PR#3393), specifically adding FixedOffset's typing. I'm unsure about the kwarg though, _tzinfos.
Here's the line I've put in typeshed. @stub42 Can you confirm the typing of _tzinfos (and, of course, let me know if the other types are wrong). The typeshed tests run, and it looks right to me... but I don't know pytz well enough. Thanks!
The text was updated successfully, but these errors were encountered:
The _tzinfos parameter is private (per the old _ prefix naming convention), and only intended for use by the unpickler. The type is some horrible data structure as you have found (and which I don't recall), but better if you can flag it as some opaque type.
Thanks for the quick reply. Given that, I might just remove the kwarg from the stub altogether, which will just let typing evaluate it to Any; if it's a complicated data structure and it's meant to be private, easier to just let it be whatever it is (i.e. no explicit/static type evaluation). Otherwise, I'm not sure what "opaque type" to flag it to!
👋 Hi! New contributor here. I'm updating the typing stubs for pytz in typeshed (PR#3393), specifically adding
FixedOffset
's typing. I'm unsure about the kwarg though,_tzinfos
.Here's the line I've put in typeshed. @stub42 Can you confirm the typing of
_tzinfos
(and, of course, let me know if the other types are wrong). The typeshed tests run, and it looks right to me... but I don't know pytz well enough. Thanks!The text was updated successfully, but these errors were encountered: