Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sports teams: Tighten validations, add to main import task, update icons #2678

Merged
merged 3 commits into from Oct 25, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Oct 25, 2019

Who is this PR for?

SHS students and educators

What problem does this PR fix?

Builds on #2677, adding the importer to the main importer so it can run each day. There are some duplicate records from past work.

What does this PR do?

Offline, I ran a task to clean up the duplicates, and then added these validations and verified they now hold. This also adds an emoji icon for new name variant.

Checklists

Which features or pages does this PR touch?

  • Student Profile
  • Team importer

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Oct 25, 2019

selfie

@kevinrobinson kevinrobinson merged commit 66215c8 into master Oct 25, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@kevinrobinson kevinrobinson deleted the feature/teams-icons-validations branch Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.