Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Fix administrate pages from config bug #2813

Merged
merged 2 commits into from May 7, 2020

Conversation

kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented May 7, 2020

Who is this PR for?

project leads

What problem does this PR fix?

The administrate admin pages for adjusting educator permissions were broken, probably in #2781. I'm not sure how this got through so long, especially when there was a fair bit of manual testing to validate the gem update and other related gem updates around that time.

There was an authorization smoke test for these routes, but those didn't notice they were getting back Rails error pages. This is the second consecutive time bumping administrate has broken these routes and we haven't caught it until a fair bit afterward (eg, #2722).

What does this PR do?

Updates the authorization smoke test to explicitly check for Rails error pages, and fixes the root config problem, with comments referencing the upstream issue in administrate about the underlying change in Sprockets 4 that led to the config change.

Checklists

Which features or pages does this PR touch?

  • Project lead admin permissions pages

Does this PR use tests to help verify we can deploy these changes quickly and confidently?
z+ [x] Improved specs for existing code in need of better test coverage

  • Manual testing made more sense here

@kevinrobinson
Copy link
Contributor Author

kevinrobinson commented May 7, 2020

The build failure is from both the yarn audit backend being down, and from the GitHub Actions cache service timing out after 10min. Going to let that sit, both are recurring issues that may need some attention :\

@kevinrobinson
Copy link
Contributor Author

kevinrobinson commented May 7, 2020

The cache in GitHub actions is unreliable (#2815) so ran test locally and disabled it so we don't continually have these issues. This PR is 🚢

@kevinrobinson kevinrobinson merged commit 3629be3 into master May 7, 2020
9 of 10 checks passed
@kevinrobinson kevinrobinson deleted the patch/administrate-css-and-smoke-test branch May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant