Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set SHARDS_OPTS=--ignore-crystal-version on Travis CI #34

Closed
Sija opened this issue Aug 30, 2020 · 4 comments
Closed

Set SHARDS_OPTS=--ignore-crystal-version on Travis CI #34

Sija opened this issue Aug 30, 2020 · 4 comments

Comments

@Sija
Copy link
Contributor

Sija commented Aug 30, 2020 •
edited
Loading

image

Otherwise nightly builds will be failing, as they do now.
@oprypin
Copy link

oprypin commented Aug 30, 2020

You can just specify crystal: ">= 0.35.1" instead.

No idea why that's not being advertised as the solution, but egh none of that made sense to me

@l3kn
Copy link
Collaborator

l3kn commented Sep 10, 2020

I've added the environment variable, the nighly build is passing now.

@oprypin Where would that go? In the shard.yml?
If you think it's a better solution, we can change it.

@oprypin
Copy link

oprypin commented Sep 10, 2020

stumpy_png/shard.yml

Line 17 in 9a7399a

crystal: 0.35.1

@Sija
Copy link
Contributor Author

Sija commented Sep 10, 2020

@l3kn Great! Closing the since the issue at hand has been resolved.

@Sija Sija closed this as completed Sep 10, 2020
@Sija Sija mentioned this issue Sep 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Sija @oprypin @l3kn