-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial work to add algolia to app #310
Conversation
This pull request is automatically deployed with Now. To access deployments, click Details below or on the icon next to each push. |
The design from #158 looked pretty good, let's go with that? |
@mxstbr I see one image related to the design for the input. Do we have any images that I can look at for reference as to how the input will look like on different devices? |
@imbhargav5 I'd do the dropdown style for tablet (768) & up and then do a takeover style (full height & width with a close X) for 767 down |
Sounds good. |
@probablyup @mxstbr I am working on the mobile nav part right now. Do you have a screenshot/design for how the search would like on smaller screens? That would really help. |
😍 Probably just the same thing but full-screen on mobile? |
@imbhargav5 I was thinking something simple like this with a close "X" in the top right corner |
@probablyup I see. This helps. 😀 |
Looks like Algolia doesn't support multiple inputs. We need two inputs, one for mobile and one for normal. How do we go about this? |
Can’t use css and a media query for the mobile look?
…On Thu, Sep 13, 2018 at 5:20 AM Bhargav Ponnapalli ***@***.***> wrote:
Looks like Algolia doesn't support multiple inputs. We need two inputs,
one for mobile and one for normal. How do we go about this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#310 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAiy1my49U7ErYAMwIcnaxpVe0vOi7emks5uajFtgaJpZM4WfEwR>
.
|
I think it's doable only if I change the structure of the navbar and mobileNavbar elements. A bit more than just media queries I would say. Will update PR in today or tomorrow. |
So, inherently, the way Docsearch appends search results right beside the input is causing some layout issues but I made an ugly, very much work in progress modal for mobile. Please take a look and see if there are some issues that we can fix before I get into styling. @probablyup |
Some notes so far:
|
Ok. So for 2 should I put a search icon beside the collapse button? |
I would figure out how the collapse works and then just move that whole component out of the collapse zone so it goes to the left of the collapse chevron |
Let's go!! |
@imbhargav5 That looks great! |
This isn't ready for merge yet. Prism is complaining about something |
I requested algolia docsearch for config to add it out app. If we have a design I will update the UI and snapshots to match the designs. We will track it all here.