Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial work to add algolia to app #310

Merged
merged 17 commits into from
Sep 24, 2018
Merged

Initial work to add algolia to app #310

merged 17 commits into from
Sep 24, 2018

Conversation

imbhargav5
Copy link
Member

I requested algolia docsearch for config to add it out app. If we have a design I will update the UI and snapshots to match the designs. We will track it all here.

@vercel
Copy link

vercel bot commented Sep 7, 2018

This pull request is automatically deployed with Now.

To access deployments, click Details below or on the icon next to each push.

@mxstbr
Copy link
Member

mxstbr commented Sep 7, 2018

The design from #158 looked pretty good, let's go with that?

@imbhargav5
Copy link
Member Author

@mxstbr I see one image related to the design for the input. Do we have any images that I can look at for reference as to how the input will look like on different devices?

@quantizor
Copy link
Contributor

@imbhargav5 I'd do the dropdown style for tablet (768) & up and then do a takeover style (full height & width with a close X) for 767 down

@imbhargav5
Copy link
Member Author

Sounds good.

@imbhargav5
Copy link
Member Author

@probablyup @mxstbr I am working on the mobile nav part right now. Do you have a screenshot/design for how the search would like on smaller screens? That would really help.

@mxstbr
Copy link
Member

mxstbr commented Sep 11, 2018

😍

Probably just the same thing but full-screen on mobile?

@quantizor
Copy link
Contributor

quantizor commented Sep 11, 2018

@imbhargav5 I was thinking something simple like this with a close "X" in the top right corner

@imbhargav5
Copy link
Member Author

@probablyup I see. This helps. 😀

@imbhargav5
Copy link
Member Author

Looks like Algolia doesn't support multiple inputs. We need two inputs, one for mobile and one for normal. How do we go about this?

@quantizor
Copy link
Contributor

quantizor commented Sep 13, 2018 via email

@imbhargav5
Copy link
Member Author

I think it's doable only if I change the structure of the navbar and mobileNavbar elements. A bit more than just media queries I would say. Will update PR in today or tomorrow.

@imbhargav5
Copy link
Member Author

So, inherently, the way Docsearch appends search results right beside the input is causing some layout issues but I made an ugly, very much work in progress modal for mobile. Please take a look and see if there are some issues that we can fix before I get into styling. @probablyup

@quantizor
Copy link
Contributor

Some notes so far:

  1. It'd be great if the hover coloring etc could be adjusted to better match our website color scheme

  2. We should have the search always be visible and live outside that collapse area for mobile

@imbhargav5
Copy link
Member Author

Ok. So for 2 should I put a search icon beside the collapse button?

@quantizor
Copy link
Contributor

I would figure out how the collapse works and then just move that whole component out of the collapse zone so it goes to the left of the collapse chevron

@imbhargav5
Copy link
Member Author

imbhargav5 commented Sep 22, 2018

Image from Gyazo

@imbhargav5
Copy link
Member Author

Let's go!!

@sag1v
Copy link
Contributor

sag1v commented Sep 23, 2018

@imbhargav5 That looks great!

@quantizor
Copy link
Contributor

This isn't ready for merge yet. Prism is complaining about something

@quantizor quantizor merged commit a9418dd into master Sep 24, 2018
@quantizor quantizor deleted the algolia branch September 24, 2018 00:44
@imbhargav5 imbhargav5 mentioned this pull request Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants