Build: Publish typings on travis publish #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sapegin do you want me to add a cookbook item for the usage of the types in components? |
|
Thanks! Yep, a cookbook entry would be nice. |
|
The cookbook has been added. |
thecodejack
reviewed
Jan 12, 2020
sapegin
reviewed
Jan 13, 2020
docs/Cookbook.md
Outdated
|
|
||
| It allows the maintainers to catch type mismatch before execution and a better developer experience. | ||
|
|
||
| It also allows users to write their customized styleguide components using typescript TSX and plugins to build it. |
There was a problem hiding this comment.
Suggested change
| It also allows users to write their customized styleguide components using typescript TSX and plugins to build it. | |
| It also allows users to write their customized style guide components using TypeScript and plugins to build it. |
What plugins do you mean here?
There was a problem hiding this comment.
I meant to leverage the type checking powers of typescript and its red squigglies to help you code.
Plugins would be vscode type checking, or Sublime Text or Atom TS plugin.
I think I can omit it as it is self explanatory.
What do you think?
There was a problem hiding this comment.
Yup, that's quite confusing for me ;-)
Co-Authored-By: Artem Sapegin <artem@sapegin.ru>
|
🎉 This PR is included in version 11.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Apr 7, 2022
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As previously mentioned, I want to be able to use the types generated by rsg in vue-styleguidist.
This publishes the types with the compiled library.
There is a known limitation:
rsg-componentaliased path have to be kept in thetsconfig.jsonof any project using the types. It should redirect tonode_modules/react-styleguidist/lib/client/rsg-component.